Fora / Nitro / create_tbody? fix; xml-simple dependency; typo in hello/app.rb (!)

collapse all - expand all
by rmela.myopenid.com, Thu, 29 Mar 2007 09:52:37 GMT
  • Raw now requires xmlsimple. I updated raw.gemspec to specify the
    dependency.
    * I tried an app that included og and admin but had no models. Og
    admin threw an exception in create_tbody? in table.rb. I think
    it’s more correct to display a zero-length table of Og types when
    there are zero Og types than it is to throw an exception.
    * My last patch left the glycerin include commented out in
    hello/app.rb. I uncommented the include so that Hello runs
    without any changes, because that’s how HelloWorld should be…

    Thanks,

    Robert Mela


by gmosx.myopenid.com, Thu, 29 Mar 2007 11:07:15 GMT

You forgot to attach the patch!

by jonathan-buch.de, Fri, 30 Mar 2007 09:37:20 GMT

I’m not sure, do we want to depend on another library?

by rmela.myopenid.com, Fri, 30 Mar 2007 21:17:08 GMT

I don’t know whether or not you want to. But whether you want to or not, you do.

I think at this point there are three options:

replace XML Simple with existing standard library XML functionality
keep XML simple, which entails adding the dependency to the gem
*do nothing - require xmlsimple, and keep the gemspec without the dependency statement

The third option in my opinion is an error -
raw will install without complaint, but will throw an exception at runtime. The dependency is a fact whether it’s expressed or not.

So options 1 or 2—either remove the dependency or, if not, then express it in the gemspec.

by gmosx.myopenid.com, Sat, 31 Mar 2007 05:20:50 GMT

perhaps we can replace xmlsimple with a library offering similar functionality in facets. In fact I may work on something along these lines. If i actually finish it I will push it to Tom.

-g.

by you, now   Attach file

Please type the code: What is this?